Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace poetry with uv #19075

Merged
merged 1 commit into from
Oct 31, 2024
Merged

Replace poetry with uv #19075

merged 1 commit into from
Oct 31, 2024
+652 −691

Conversation

nsoranzo
Copy link
Member

for lightning-fast Python dependency updates.

To update all dependencies (as done by the GitHub action):

$ make update-dependencies

To update only one package:

./lib/galaxy/dependencies/update.sh -p <PKG>

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@nsoranzo nsoranzo mentioned this pull request Oct 29, 2024
Merged
17 tasks
jmchilton
jmchilton approved these changes Oct 30, 2024
View reviewed changes
Copy link
Member

@jmchilton jmchilton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Brilliant!

@nsoranzo nsoranzo marked this pull request as ready for review October 31, 2024 10:03
@github-actions github-actions bot added this to the 24.2 milestone Oct 31, 2024
@nsoranzo
Copy link
Member Author

uv 0.4.29 fixed the last remaining showstopper astral-sh/uv#8658 .
The only change since John's approval is the fix for the rucio-clients Python marker, so, unless anybody shouts, I am going to merge when tests are green.

@nsoranzo
Replace poetry with uv
93078d9 
for lightning-fast Python dependency updates.

To update all dependencies (as done by the GitHub action):

$ make update-dependencies

To update only one package:

./lib/galaxy/dependencies/update.sh -p <PKG>
@nsoranzo nsoranzo merged commit 0f06c9b into galaxyproject:dev Oct 31, 2024
53 of 54 checks passed
@nsoranzo nsoranzo deleted the uv branch October 31, 2024 12:08
@jdavcs jdavcs added the highlight/dev Included in admin/dev release notes label Oct 31, 2024
@arash77 arash77 mentioned this pull request Nov 5, 2024
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmchilton jmchilton jmchilton approved these changes

Assignees
No one assigned
Labels
area/dependencies highlight/dev Included in admin/dev release notes kind/enhancement
Projects
None yet
Milestone
24.2
Development

Successfully merging this pull request may close these issues.
3 participants
@nsoranzo @jmchilton @jdavcs